Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask requires Asyncio support for Dataloaders #65

Open
wakemaster39 opened this issue Oct 8, 2020 · 0 comments · May be fixed by #66
Open

Flask requires Asyncio support for Dataloaders #65

wakemaster39 opened this issue Oct 8, 2020 · 0 comments · May be fixed by #66
Labels
type: question or discussion Issue discussing or asking a question about graphql-server-core

Comments

@wakemaster39
Copy link

With the death of promises, https://github.com/syrusakbary/aiodataloader is the current only implementation of dataloaders that I can find. To use this in a synchronous framework like flask, you need to have async support. I agree the default needs for this to be off, but there needs to be a way to turn this on so that people can shoot themselves in the foot if they do it wrong.

@wakemaster39 wakemaster39 linked a pull request Oct 8, 2020 that will close this issue
@KingDarBoja KingDarBoja added the type: question or discussion Issue discussing or asking a question about graphql-server-core label Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question or discussion Issue discussing or asking a question about graphql-server-core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants