Check that caching is enabled before using it #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
force-pushed
the
check-before-cache
branch
from
a8d4828
to
3850137
Compare
leebyron
force-pushed
the
check-before-cache
branch
from
3850137
to
97ac2a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing behavior for a DataLoader with caching disabled is to still create a cache Map, which allows the
prime()andclear()methods to continue to interact with that cache even though nothing will read from it. A classic "write-only cache"!This fixes this behavior by not creating a cache Map for DataLoaders with caching disabled and checks for this case before interacting with the cache.
Fixes #161