Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Returns the keys type of the batch fn to ReadonlyArray #219

Merged
merged 1 commit into from Nov 14, 2019

Conversation

leebyron
Copy link
Contributor

Fixes an issue caused by #214 where batch functions which attempt to use array methods like map or filter would become typescript errors. This retains the ArrayLike return type but provides ReadonlyArray for the keys argument to the function.

@leebyron leebyron merged commit 44977c0 into master Nov 14, 2019
@leebyron leebyron deleted the fix-batch-keys-type branch November 14, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant