[BREAKING] Resolve cached values after batch dispatch #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
force-pushed
the
batch-object
branch
from
5649bff
to
aa52a25
Compare
leebyron
force-pushed
the
batched-cache
branch
from
5f7d2d7
to
488a7ae
Compare
leebyron
force-pushed
the
batch-object
branch
from
aa52a25
to
fe41438
Compare
leebyron
force-pushed
the
batched-cache
branch
from
488a7ae
to
fdbb624
Compare
Sarcasm
reviewed
Nov 28, 2019
| (maxBatchSize === 0 || | ||
| (existingBatch.keys.length < maxBatchSize && | ||
| (!existingBatch.cacheHits || | ||
| existingBatch.cacheHits.length < maxBatchSize))) |
There was a problem hiding this comment.
I'm curious.
According to the README:
maxBatchSize
Limits the number of items that get passed in to the batchLoadFn.
Since batchLoadFn isn't called for the cache hits, is there any reasons for cacheHits to use this limit?
If the maxBatchSize was an "output batch size", then I assume we would want the limit to be something like:
(keys.length + cacheHits.length) < maxBatchSize
There was a problem hiding this comment.
I found the same issue when hitting the limit with cache hits, my batchLoadFn is always called with 1 key only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate of #113, however when built atop the new
Batchabstraction introduced in #220 the implementation becomes much simpler.This change is breaking since it results in timing differences when cached values are resolved which can affect whole program behavior. However hopefully this behavior change is for the better since it should result in better whole-program optimization.
Fixes #224
Closes #113
Fixes #97