Support custom schedulers #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
force-pushed
the
custom-scheduler
branch
from
4f21d90
to
ddfa4dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally discussed as early as issue #1! DataLoader's primary value is providing performant coalescing batching. It does this by exploiting knowledge of how Node's job queue runs (and just using setImmediate in the browser). However many ports of this library have not found equivalent mechanisms in their host runtime and have instead opted for either a timer-based solution, manual dispatching, or tight integration into a custom GraphQL executor. All of these approaches are perfectly valid and it's time that the original implementation provide the capability to explore these mechanisms as well.
This PR allows overriding the built-in default
enqueuePostPromiseJobscheduler with any arbitrary function. The Readme documentation has been amended to show examples of time-window collection (viasetTimeout) and manual dispatch.Closes #225