Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export react with cdn bundle #3555

Open
acao opened this issue Mar 8, 2024 · 0 comments
Open

Don't export react with cdn bundle #3555

acao opened this issue Mar 8, 2024 · 0 comments

Comments

@acao
Copy link
Member

acao commented Mar 8, 2024

we don't need this line, because the CDN example already shows importing React at React global umd namespace, so React is available without bundling it with graphiql/graphiql.min .js

GraphiQL.React = GraphiQLReact;

this will require tweaking the plugin vite configs as well which are configured for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant