Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audits): Notices section for optional recommendations #76

Merged
merged 7 commits into from
Apr 12, 2023

Conversation

enisdenjo
Copy link
Member

@enisdenjo enisdenjo commented Apr 11, 2023

In light of graphql/graphql-over-http#241, after #62.

@enisdenjo enisdenjo marked this pull request as ready for review April 11, 2023 00:53
benjie
benjie previously requested changes Apr 11, 2023
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like it should be ERROR > WARNING > INFO rather than ERROR > INFO > WARNING.

SHOULD assume application/json content-type when accept is missing seems to be using GET even on server that only support POST, so is incorrectly triggering warnings?

@enisdenjo
Copy link
Member Author

enisdenjo commented Apr 12, 2023

Feels like it should be ERROR > WARNING > INFO rather than ERROR > INFO > WARNING.

Actually its INFO > WARNING > ERROR. But yeah, more importance should be given to the top. I'll reorder in a separate PR.

SHOULD assume application/json content-type when accept is missing seems to be using GET even on server that only support POST, so is incorrectly triggering warnings?

Will be fixed with #77.

@enisdenjo enisdenjo requested a review from benjie April 12, 2023 10:27
@enisdenjo enisdenjo merged commit b8bdc71 into main Apr 12, 2023
17 checks passed
@enisdenjo enisdenjo deleted the recommendations branch April 12, 2023 16:39
enisdenjo pushed a commit that referenced this pull request Apr 14, 2023
# [1.18.0](v1.17.1...v1.18.0) (2023-04-14)

### Bug Fixes

* **audits/server:** Avoid auditing non well-formatted GraphQL-over-HTTP requests ([#62](#62)) ([d72e344](d72e344))
* **audits/server:** Prefer using POST ([#77](#77)) ([8cd7dfb](8cd7dfb))
* **handler:** Stringify errors by exposing only the message ([cabf8a9](cabf8a9))

### Features

* **audits:** Notices section for optional recommendations ([#76](#76)) ([b8bdc71](b8bdc71))
* **handler:** Error formatter function ([#78](#78)) ([c0eaeb4](c0eaeb4))
@enisdenjo
Copy link
Member Author

🎉 This PR is included in version 1.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@enisdenjo enisdenjo added the released Has been released and published label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Has been released and published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants