From 626f2d2bf68cc8add7347cc1c921c9a8e2fbda52 Mon Sep 17 00:00:00 2001 From: Ivan Goncharov Date: Wed, 27 Apr 2022 11:53:26 +0300 Subject: [PATCH] ci: disable Codecov and measure test coverage on every run (#3548) --- .c8rc.json | 2 +- .github/workflows/ci.yml | 30 +----------------------------- README.md | 1 - codecov.yml | 14 -------------- cspell.yml | 1 - package.json | 3 +-- 6 files changed, 3 insertions(+), 48 deletions(-) delete mode 100644 codecov.yml diff --git a/.c8rc.json b/.c8rc.json index 22bb450ee4..7d119daeee 100644 --- a/.c8rc.json +++ b/.c8rc.json @@ -14,7 +14,7 @@ "temp-directory": "coverage", "report-dir": "coverage", "skip-full": true, - "reporter": ["json", "html", "text"], + "reporter": ["html", "text"], "check-coverage": true, "branches": 100, "lines": 100, diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index adfa1c5bd7..959751b264 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -121,40 +121,12 @@ jobs: - name: Run Tests run: npm run fuzzonly - coverage: - name: Measure test coverage - runs-on: ubuntu-latest - steps: - - name: Checkout repo - uses: actions/checkout@v2 - with: - persist-credentials: false - - - name: Setup Node.js - uses: actions/setup-node@v2 - with: - cache: npm - node-version-file: '.node-version' - - - name: Install Dependencies - run: npm ci --ignore-scripts - - - name: Run tests and measure code coverage - run: npm run testonly:cover - - - name: Upload coverage to Codecov - if: ${{ always() }} - uses: codecov/codecov-action@v1 - with: - file: ./coverage/coverage-final.json - fail_ci_if_error: true - test: name: Run tests on Node v${{ matrix.node_version_to_setup }} runs-on: ubuntu-latest strategy: matrix: - node_version_to_setup: [12, 14, 16, 17] + node_version_to_setup: [14, 16, 18] steps: - name: Checkout repo uses: actions/checkout@v2 diff --git a/README.md b/README.md index 34753472f9..d2a9137976 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,6 @@ The JavaScript reference implementation for GraphQL, a query language for APIs c [![npm version](https://badge.fury.io/js/graphql.svg)](https://badge.fury.io/js/graphql) [![Build Status](https://github.com/graphql/graphql-js/workflows/CI/badge.svg?branch=main)](https://github.com/graphql/graphql-js/actions?query=branch%3Amain) -[![Coverage Status](https://codecov.io/gh/graphql/graphql-js/branch/main/graph/badge.svg)](https://codecov.io/gh/graphql/graphql-js) See more complete documentation at https://graphql.org/ and https://graphql.org/graphql-js/. diff --git a/codecov.yml b/codecov.yml deleted file mode 100644 index 7c05fac380..0000000000 --- a/codecov.yml +++ /dev/null @@ -1,14 +0,0 @@ -codecov: - notify: - require_ci_to_pass: true - -parsers: - javascript: - enable_partials: true - -comment: false -coverage: - status: - project: - default: - target: auto diff --git a/cspell.yml b/cspell.yml index 8770a4d781..f3c8b359a4 100644 --- a/cspell.yml +++ b/cspell.yml @@ -46,7 +46,6 @@ words: # TODO: contribute upstream - deno - - codecov # TODO: remove bellow words - QLID # GraphQLID diff --git a/package.json b/package.json index 984aa36faa..7b90fe1d97 100644 --- a/package.json +++ b/package.json @@ -38,8 +38,7 @@ "test": "npm run lint && npm run check && npm run testonly && npm run prettier:check && npm run check:spelling && npm run check:integrations", "lint": "eslint --cache --max-warnings 0 .", "check": "tsc --pretty", - "testonly": "mocha --full-trace src/**/__tests__/**/*-test.ts", - "testonly:cover": "c8 npm run testonly", + "testonly": "c8 mocha --full-trace src/**/__tests__/**/*-test.ts", "prettier": "prettier --write --list-different .", "prettier:check": "prettier --check .", "check:spelling": "cspell --cache --no-progress '**/*'",