From d1c4e7d0c86bcc921c778ad692e644c828d017bd Mon Sep 17 00:00:00 2001 From: Ivan Goncharov Date: Thu, 6 Sep 2018 22:12:03 +0300 Subject: [PATCH] Add missing ESLint rules as comments (#1503) Idea is to first add all of them as comment and than enable on per rule basis. --- .eslintrc.yml | 115 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 115 insertions(+) diff --git a/.eslintrc.yml b/.eslintrc.yml index 39aed1f1ab..45f7901f20 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -38,19 +38,47 @@ rules: # `eslint-plugin-flowtype` rule list based on `v2.50.0` # https://github.com/gajus/eslint-plugin-flowtype#eslint-plugin-flowtype + #flowtype/array-style-complex-type: undecided + #flowtype/array-style-simple-type: undecided + #flowtype/boolean-style: undecided flowtype/define-flow-type: error + #flowtype/delimiter-dangle: undecided + #flowtype/generic-spacing: undecided + #flowtype/newline-after-flow-annotation: undecided + #flowtype/no-dupe-keys: undecided + #flowtype/no-existential-type: undecided + #flowtype/no-flow-fix-me-comments: undecided + #flowtype/no-mutable-array: undecided + #flowtype/no-primitive-constructor-types: undecided + #flowtype/no-types-missing-file-annotation: undecided + #flowtype/no-unused-expressions: undecided flowtype/no-weak-types: [error, {any: false}] + #flowtype/object-type-delimiter: undecided + #flowtype/require-exact-type: undecided + #flowtype/require-parameter-type: undecided + #flowtype/require-return-type: undecided + #flowtype/require-types-at-top: undecided + #flowtype/require-valid-file-annotation: undecided + #flowtype/require-variable-type: undecided flowtype/semi: off + #flowtype/sort-keys: undecided flowtype/space-after-type-colon: off flowtype/space-before-generic-bracket: off flowtype/space-before-type-colon: off + #flowtype/type-id-match: undecided + #flowtype/type-import-style: undecided flowtype/union-intersection-spacing: off flowtype/use-flow-type: error + #flowtype/valid-syntax: undecided # Possible Errors # https://eslint.org/docs/rules/#possible-errors + #for-direction: undecided + #getter-return: undecided + #no-async-promise-executor: undecided no-await-in-loop: error + #no-compare-neg-zero: undecided no-cond-assign: error no-console: warn no-constant-condition: error @@ -69,12 +97,17 @@ rules: no-inner-declarations: [error, functions] no-invalid-regexp: error no-irregular-whitespace: error + #no-misleading-character-class: undecided no-obj-calls: error + #no-prototype-builtins: undecided no-regex-spaces: error no-sparse-arrays: error + #no-template-curly-in-string: undecided no-unexpected-multiline: off no-unreachable: error + #no-unsafe-finally: undecided no-unsafe-negation: error + #require-atomic-updates: undecided use-isnan: error valid-jsdoc: off valid-typeof: error @@ -82,7 +115,10 @@ rules: # Best Practices # https://eslint.org/docs/rules/#best-practices + #accessor-pairs: undecided + #array-callback-return: undecided block-scoped-var: off + #class-methods-use-this: undecided complexity: off consistent-return: off curly: [error, all] @@ -91,23 +127,31 @@ rules: dot-notation: off eqeqeq: [error, smart] guard-for-in: error + #max-classes-per-file: undecided no-alert: error no-caller: error + #no-case-declarations: undecided no-div-regex: error no-else-return: error + #no-empty-function: undecided + #no-empty-pattern: undecided no-eq-null: off no-eval: error no-extend-native: error no-extra-bind: error + #no-extra-label: undecided no-fallthrough: error no-floating-decimal: off + #no-global-assign: undecided no-implicit-coercion: error + #no-implicit-globals: undecided no-implied-eval: error no-invalid-this: off no-iterator: error no-labels: [error, {allowLoop: true}] no-lone-blocks: error no-loop-func: off + #no-magic-numbers: undecided no-multi-spaces: off no-multi-str: error no-new: error @@ -118,19 +162,28 @@ rules: no-param-reassign: error no-proto: error no-redeclare: error + #no-restricted-properties: undecided no-return-assign: error + #no-return-await: undecided no-script-url: error + #no-self-assign: undecided no-self-compare: off no-sequences: off no-throw-literal: error + #no-unmodified-loop-condition: undecided no-unused-expressions: error + #no-unused-labels: undecided no-useless-call: error + #no-useless-concat: undecided no-useless-escape: error no-useless-return: error no-void: error no-warning-comments: off no-with: error + #prefer-promise-reject-errors: undecided radix: error + #require-await: undecided + #require-unicode-regexp: undecided vars-on-top: off wrap-iife: off yoda: [error, never, {exceptRange: true}] @@ -146,6 +199,7 @@ rules: init-declarations: off no-delete-var: error no-label-var: error + #no-restricted-globals: undecided no-shadow: error no-shadow-restricted-names: error no-undef: error @@ -158,7 +212,9 @@ rules: # https://eslint.org/docs/rules/#nodejs-and-commonjs callback-return: error + #global-require: undecided handle-callback-err: [error, error] + #no-buffer-constructor: undecided no-mixed-requires: [error, true] no-new-require: error no-path-concat: error @@ -170,8 +226,13 @@ rules: # Stylistic Issues # https://eslint.org/docs/rules/#stylistic-issues + #array-bracket-newline: undecided + #array-bracket-spacing: undecided + #array-element-newline: undecided + #block-spacing: undecided brace-style: off camelcase: [error, {properties: always}] + #capitalized-comments: undecided comma-dangle: off comma-spacing: off comma-style: off @@ -179,66 +240,120 @@ rules: consistent-this: off eol-last: off func-call-spacing: off + #func-name-matching: undecided func-names: off func-style: off + #function-paren-newline: undecided + #id-blacklist: undecided id-length: off id-match: [error, "^(?:_?[a-zA-Z0-9]*)|[_A-Z0-9]+$"] + #implicit-arrow-linebreak: undecided indent: off + #jsx-quotes: undecided key-spacing: off keyword-spacing: off + #line-comment-position: undecided linebreak-style: error lines-around-comment: off + #lines-between-class-members: undecided max-depth: off max-len: off + #max-lines: undecided + #max-lines-per-function: undecided max-nested-callbacks: off max-params: off max-statements: off + #max-statements-per-line: undecided + #multiline-comment-style: undecided + #multiline-ternary: undecided new-cap: off new-parens: off + #newline-per-chained-call: undecided no-array-constructor: error no-bitwise: off no-continue: off no-inline-comments: off no-lonely-if: error + #no-mixed-operators: undecided no-mixed-spaces-and-tabs: off + #no-multi-assign: undecided no-multiple-empty-lines: off + #no-negated-condition: undecided no-nested-ternary: off no-new-object: error no-plusplus: off no-spaced-func: off + #no-restricted-syntax: undecided + #no-tabs: undecided no-ternary: off no-trailing-spaces: off no-underscore-dangle: off no-unneeded-ternary: error + #no-whitespace-before-property: undecided + #nonblock-statement-body-position: undecided + #object-curly-newline: undecided object-curly-spacing: [off, always] + #object-property-newline: undecided one-var: [error, never] + #one-var-declaration-per-line: undecided operator-assignment: [error, always] + #operator-linebreak: undecided padded-blocks: off padding-line-between-statements: off + #prefer-object-spread: undecided quote-props: off + #quotes: undecided + #require-jsdoc: undecided semi: off semi-spacing: off + #semi-style: undecided + #sort-keys: undecided sort-vars: off space-before-blocks: off + #space-before-function-paren: undecided space-in-parens: off space-infix-ops: off space-unary-ops: off spaced-comment: [error, always] + #switch-colon-spacing: undecided + #template-tag-spacing: undecided + #unicode-bom: undecided wrap-regex: off # ECMAScript 6 # https://eslint.org/docs/rules/#ecmascript-6 + #arrow-body-style: undecided arrow-parens: off arrow-spacing: off + #constructor-super: undecided + #generator-star-spacing: undecided no-class-assign: error + #no-confusing-arrow: undecided no-const-assign: error + #no-dupe-class-members: undecided + #no-duplicate-imports: undecided + #no-new-symbol: undecided + #no-restricted-imports: undecided no-this-before-super: error + #no-useless-computed-key: undecided + #no-useless-constructor: undecided + #no-useless-rename: undecided no-var: error object-shorthand: [error, always] + #prefer-arrow-callback: undecided prefer-const: error + #prefer-destructuring: undecided + #prefer-numeric-literals: undecided + #prefer-rest-params: undecided prefer-spread: off + #prefer-template: undecided require-yield: off + #rest-spread-spacing: undecided + #sort-imports: undecided + #symbol-description: undecided + #template-curly-spacing: undecided + #yield-star-spacing: undecided overrides: - files: "*"