Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMIT FREEZE DUE TO TS MIGRATION (until 24.05.2021) #3087

Closed
IvanGoncharov opened this issue May 14, 2021 · 4 comments
Closed

COMMIT FREEZE DUE TO TS MIGRATION (until 24.05.2021) #3087

IvanGoncharov opened this issue May 14, 2021 · 4 comments

Comments

@IvanGoncharov
Copy link
Member

As discussed on last WG we need to pull a trigger on long-overdue TS conversion.
Since we can't finish it in one merge and also expect some stuff to be broken in a process we need to do a temporary freeze on all commits not related to this conversion.
We should finish and return back to normal processes before 22.04.2021

@IvanGoncharov IvanGoncharov pinned this issue May 14, 2021
@aprilrd
Copy link

aprilrd commented May 16, 2021

Hello, could you double-check the due date? I wonder if you meant 22.06.2021, not 22.04.2021.

@leebyron
Copy link
Contributor

One week freeze, planned completion by 22.5.2021, May 22

@IvanGoncharov IvanGoncharov changed the title COMMIT FREEZE DUE TO TS MIGRATION (until 22.04.2021) COMMIT FREEZE DUE TO TS MIGRATION (until 22.05.2021) May 18, 2021
@IvanGoncharov
Copy link
Member Author

Update: I run a diff comparing generated typings to the handwritten ones with have at the moment.
Some of the results were very surprising so I need a few more days to finish (until Monday 24th).
If someone has anything important to merge before that date, please feel free to ping me on this issue.

@IvanGoncharov IvanGoncharov changed the title COMMIT FREEZE DUE TO TS MIGRATION (until 22.05.2021) COMMIT FREEZE DUE TO TS MIGRATION (until ~~22~~24.05.2021) May 21, 2021
@IvanGoncharov IvanGoncharov changed the title COMMIT FREEZE DUE TO TS MIGRATION (until ~~22~~24.05.2021) COMMIT FREEZE DUE TO TS MIGRATION (until 24.05.2021) May 21, 2021
@IvanGoncharov
Copy link
Member Author

Merged #3110 so main is unfrozen now.
But we still have a bunch of @ts-expect-errors and disable some of the strict checks in tsconfig.json.

@IvanGoncharov IvanGoncharov unpinned this issue May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants