Fix crash in node when mixing sync/async resolvers #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
chrskrchr
force-pushed
the
ck.unhandledRejection2
branch
from
4104cd8
to
7d48c7e
Compare
chrskrchr
added a commit
to chrskrchr/graphql-js
that referenced
this pull request
Aug 18, 2022
chrskrchr
added a commit
to chrskrchr/graphql-js
that referenced
this pull request
Aug 18, 2022
|
@saihaj - could you take a look at this PR when you have a moment? A similar had been submitted and approved previously (so it might look familiar), but I don't want to mention that PR here for risk of tainting it with CLA issues like the last PR. 😬 |
saihaj
approved these changes
Oct 5, 2022
IvanGoncharov
force-pushed
the
ck.unhandledRejection2
branch
from
f56f716
to
880d3bd
Compare
IvanGoncharov
added
the
PR: bug fix 🐞
IvanGoncharov
added a commit
that referenced
this pull request
Oct 17, 2022
#3708) Co-authored-by: Ivan Goncharov <ivan.goncharov.ua@gmail.com>
IvanGoncharov
added a commit
that referenced
this pull request
Oct 17, 2022
#3707) Co-authored-by: Ivan Goncharov <ivan.goncharov.ua@gmail.com>
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
Oct 18, 2022
including mixture of sync/async errors in lists following graphql#3706 fix for field execution
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
Oct 19, 2022
including mixture of sync/async errors in lists following graphql#3706 fix for field execution
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
Jan 3, 2023
following graphql#3706 fix for field execution
yaacovCR
added a commit
to yaacovCR/graphql-executor
that referenced
this pull request
Jan 3, 2023
following graphql#3706 fix for field execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3528
Ensures that if
executeFieldsencounters a mix of promises and thrown errors, the promises will be awaited before throwing the error.