Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dead code from instanceOf.ts is not tree shaked for browser due globalThis.process #3925

Open
dimaMachina opened this issue Jun 23, 2023 · 2 comments

Comments

@dimaMachina
Copy link

after #3923 and #3501 dead code from instanceOf is no longer tree shaked for browsers

@IvanGoncharov wrote

Bundlers incorrectly replace (probably RegExp) process.env.NODE_ENV with "development" resulting in:

(_globalThis$process = globalThis.process) === null ||
_globalThis$process === void 0
  ? void 0
  : _globalThis$"development";

but this happens only when using globalThis.process.env.NODE_ENV

@vdineva
Copy link

vdineva commented Sep 28, 2023

Any update on this issue? This is a blocker for us to upgrade to newer versions of graphql and there's an advisory for the version we're currently on: GHSA-9pv7-vfvm-6vr7

@radesai21
Copy link

Can we get an update on this? This is a security warning caused by this GHSA-9pv7-vfvm-6vr7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@vdineva @dimaMachina @radesai21 and others