Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollup-plugin-inject: failed to parse graphql/jsutils/instanceOf.mjs #3928

Open
iBobik opened this issue Jun 27, 2023 · 5 comments
Open

rollup-plugin-inject: failed to parse graphql/jsutils/instanceOf.mjs #3928

iBobik opened this issue Jun 27, 2023 · 5 comments

Comments

@iBobik
Copy link

iBobik commented Jun 27, 2023

When this library is used in the Nuxt 3 project and compiled for Cloudflare it fails like this:

ℹ Building Nitro Server (preset: cloudflare-pages)                  nitro 19:16:00
(inject plugin) rollup-plugin-inject: failed to parse /home/projects/github-twqhau-upewai/node_modules/graphql/jsutils/instanceOf.mjs. Consider restricting the plugin to particular files via options.include

[nitro 19:16:14]  ERROR  RollupError: Unexpected token (Note that you need plugins to import files that are not JavaScript)


10:   /* c8 ignore next 6 */
11:   // FIXME: https://github.com/graphql/graphql-js/issues/2317
12:   globalThis.process && globalThis.process.env.NODE_ENV === 'production'
                                       ^
13:     ? function instanceOf(value, constructor) {
14:         return value instanceof constructor;


[19:16:14]  ERROR  Unexpected token (Note that you need plugins to import files that are not JavaScript)

  at error (<anonymous>)
  at setSource (<anonymous>)
  at  (<anonymous>)

Happens in version 16.7.1 and 16.7.0 but works with 16.6.0 and 17.0.0-alpha.2.

Repro: https://stackblitz.com/edit/github-twqhau-upewai
Start with: NITRO_PRESET=cloudflare-pages npm run build

@Aietes
Copy link

Aietes commented Jun 29, 2023

This is also tracked as an issue in Nuxt and nitro: nuxt/nuxt#21768. Other issues like #3918 also refer to the same problem, but it seem it will be solved soon by PR #3927.

The module tries to access globalThis.process, which makes the Cloudflare pages deployment fail. You can't access process in Cloudflare, as it's a node-only API. Technically it should be poyfilled by unenv, but there seems to be an issue preventing this. As a work-around, in our project we are currently patching the respective code in the graphql module.

pnpm patch graphql
code <generated_folder>

In node_modules/graphql/jsutils/instanceOf.mjs remove the code that tries to access process.

export const instanceOf = function instanceOf(value, constructor) {
  return value instanceof constructor
}

Apply the patch.

pnpm patch-commit <generated_folder>

The resulting patch should appear in package.json to be applied during deployment on Cloudflare.

  "pnpm": {
    "patchedDependencies": {
      "graphql@16.7.1": "patches/graphql@16.7.1.patch"
    }
  }

@utsavkapoor
Copy link

Any updates on the fix ? I was checking the PR but that also doesnt seem to have merged.

@jgalbsss
Copy link

Bumping this...

@websmithcode
Copy link

UP

1 similar comment
@sofialapteva
Copy link

UP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@iBobik @Aietes @utsavkapoor @sofialapteva @websmithcode @jgalbsss and others