From c664093cfeff055f95ef2ad9a85629f787e02031 Mon Sep 17 00:00:00 2001 From: Christoph Zwerschke Date: Sat, 11 Dec 2021 22:28:10 +0100 Subject: [PATCH 1/3] assertName-test: test new instead of deprecated function --- .c8rc.json | 1 + src/type/__tests__/assertName-test.ts | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.c8rc.json b/.c8rc.json index 100c6202c9..22bb450ee4 100644 --- a/.c8rc.json +++ b/.c8rc.json @@ -7,6 +7,7 @@ "src/jsutils/Maybe.ts", "src/jsutils/ObjMap.ts", "src/jsutils/PromiseOrValue.ts", + "src/utilities/assertValidName.ts", "src/utilities/typedQueryDocumentNode.ts" ], "clean": true, diff --git a/src/type/__tests__/assertName-test.ts b/src/type/__tests__/assertName-test.ts index 5bc1a12b83..63fa40d31c 100644 --- a/src/type/__tests__/assertName-test.ts +++ b/src/type/__tests__/assertName-test.ts @@ -2,10 +2,9 @@ import { expect } from 'chai'; import { describe, it } from 'mocha'; import { assertName, assertEnumValueName } from '../assertName'; -import { assertValidName } from '../../utilities/assertValidName'; -describe('assertValidName()', () => { - assertValidName('test'); +describe('assertName()', () => { + assertName('test'); it('passthrough valid name', () => { expect(assertName('_ValidName123')).to.equal('_ValidName123'); }); From 8edbc530c3a53b02c5506c8f04bdfa5c892bd0dc Mon Sep 17 00:00:00 2001 From: Ivan Goncharov Date: Tue, 14 Dec 2021 17:48:37 +0200 Subject: [PATCH 2/3] Update src/type/__tests__/assertName-test.ts --- src/type/__tests__/assertName-test.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/type/__tests__/assertName-test.ts b/src/type/__tests__/assertName-test.ts index 63fa40d31c..2814a6d77d 100644 --- a/src/type/__tests__/assertName-test.ts +++ b/src/type/__tests__/assertName-test.ts @@ -4,7 +4,6 @@ import { describe, it } from 'mocha'; import { assertName, assertEnumValueName } from '../assertName'; describe('assertName()', () => { - assertName('test'); it('passthrough valid name', () => { expect(assertName('_ValidName123')).to.equal('_ValidName123'); }); From d91d21bc6086958d665b7aa39a0e84ee26026ae2 Mon Sep 17 00:00:00 2001 From: Ivan Goncharov Date: Tue, 14 Dec 2021 17:59:35 +0200 Subject: [PATCH 3/3] review changes --- src/type/__tests__/assertName-test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/type/__tests__/assertName-test.ts b/src/type/__tests__/assertName-test.ts index 2814a6d77d..4baf79c763 100644 --- a/src/type/__tests__/assertName-test.ts +++ b/src/type/__tests__/assertName-test.ts @@ -3,7 +3,7 @@ import { describe, it } from 'mocha'; import { assertName, assertEnumValueName } from '../assertName'; -describe('assertName()', () => { +describe('assertName', () => { it('passthrough valid name', () => { expect(assertName('_ValidName123')).to.equal('_ValidName123'); }); @@ -32,7 +32,7 @@ describe('assertName()', () => { }); }); -describe('assertEnumValueName()', () => { +describe('assertEnumValueName', () => { it('passthrough valid name', () => { expect(assertEnumValueName('_ValidName123')).to.equal('_ValidName123'); });