You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What OS and OS version are you experiencing the issue(s) on?
Windows 10
What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?
graphql-playground-react 1.7.27
What is the expected behavior?
The package should not install react-redux and redux
What is the actual behavior?
The package installs react-redux and redux
What steps may we take to reproduce the behavior?
Create a new create-react-app using yarn as package manager
Install graphql-playground-react and react-redux to import the Provider from
Use the Playground React component as described in the docs, wrapped by the Provider
start the app and see it fail
The issue is that Redux and React redux and such kind of packages that should not occur in multiple versions within the same app. Therefore, they should not be installed by graphql-playground-react but they should be marked as devDependencies and peerDependencies.
Note that the issue happens with yarn because of its hoisting behavior, and it doesn't happen when using npm. Regardless, it's conceptually wrong to embed such dependencies and it should be documented that they need to be installed by the hosting application instead.
The text was updated successfully, but these errors were encountered:
@idiglove this issue is fairly old and I don't have the repro at hand anymore, but I suspect that the errors you posted are the manifestation of the issue.
This issue pertains to the following package(s):
What OS and OS version are you experiencing the issue(s) on?
Windows 10
What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?
graphql-playground-react 1.7.27
What is the expected behavior?
The package should not install react-redux and redux
What is the actual behavior?
The package installs react-redux and redux
What steps may we take to reproduce the behavior?
The issue is that Redux and React redux and such kind of packages that should not occur in multiple versions within the same app. Therefore, they should not be installed by graphql-playground-react but they should be marked as devDependencies and peerDependencies.
Note that the issue happens with yarn because of its hoisting behavior, and it doesn't happen when using npm. Regardless, it's conceptually wrong to embed such dependencies and it should be documented that they need to be installed by the hosting application instead.
The text was updated successfully, but these errors were encountered: