Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2020-07-02] Moving the @deprecated directive on Input Fields RFC to Stage 2 #507

Closed
benjie opened this issue Oct 1, 2020 · 5 comments
Closed
Assignees
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.

Comments

@benjie
Copy link
Member

benjie commented Oct 1, 2020

[ACTION - Lee] - Add RFC 2 tag to PR
[ACTION] - Add SHOULD statement to spec recommending that it is generally ill-advised to add @deprecated to a non-null argument or input field unless there is a default value provided.
[ACTION] - merge spec PR to master
[ACTION - Ivan] - Add schema validation to GraphQL.js that enforces @deprecated on nonnull Moved to #518
[ACTION - Evan] - talk to Shopify team and others to determine SHOULD vs MUST. Moved to #517


Note: Action Item issues are reviewed and closed during Working Group
meetings.

@benjie benjie added this to To do in Actions 2020-07-02 via automation Oct 1, 2020
@benjie
Copy link
Member Author

benjie commented Oct 1, 2020

Sorry that's a lot of actions; we can absolutely split them up but I'm trying to get them filed before the WG 😬

@eapache
Copy link
Member

eapache commented Oct 1, 2020

(my part of this was completed in August)

@benjie
Copy link
Member Author

benjie commented Oct 2, 2020

Thanks; separated out to #517 👍

@benjie
Copy link
Member Author

benjie commented Dec 4, 2020

I'm not sure exactly what the state of this is; graphql/graphql-spec#525 has RFC1 and is merged; perhaps it was jumped up a couple RFC levels without the label being changed? Either way, I think this is ready for review.

@benjie benjie added the Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings. label Dec 4, 2020
@benjie
Copy link
Member Author

benjie commented Feb 4, 2021

@IvanGoncharov says he needs to check a small validation rule to make sure this is completely ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
No open projects
Development

No branches or pull requests

4 participants