Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2020-12-03] Complete GraphQL.js implementation of subscription introspection validation rule #564

Closed
benjie opened this issue Dec 4, 2020 · 1 comment
Assignees
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.

Comments

@benjie
Copy link
Member

benjie commented Dec 4, 2020

graphql/graphql-spec#776 was made RFC 1 (Proposal) during the WG call; next month we should aim to advance it to RFC 2 (Draft). The main task for this is to advance this GraphQL.js PR: graphql/graphql-js#2861


Note: Action Item issues are reviewed and closed during Working Group
meetings.

@benjie benjie self-assigned this Dec 4, 2020
@benjie benjie added this to To do in Actions 2020-12-03 via automation Dec 4, 2020
@benjie
Copy link
Member Author

benjie commented Dec 5, 2020

Implementation is now passing CI checks; assigned to @IvanGoncharov for further review:

graphql/graphql-js#2861

(Note: this also fixes graphql/graphql-js#2715 which seems to be a bug in the reference implementation's one-field subscription validation rule?)

@benjie benjie added the Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings. label Dec 5, 2020
@benjie benjie closed this as completed Jan 7, 2021
Actions 2020-12-03 automation moved this from To do to Done Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
No open projects
Development

No branches or pull requests

2 participants