Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2021-05-13] Raise a GraphQL.js PR for preventing @skip/@include on subscriptions #695

Closed
benjie opened this issue Jun 1, 2021 · 3 comments
Closed

[2021-05-13] Raise a GraphQL.js PR for preventing @skip/@include on subscriptions #695

benjie opened this issue Jun 1, 2021 · 3 comments
Assignees
@benjie
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
Actions 2021-05-13 Actions 2021-09-02

Comments

@benjie
Copy link
Member

benjie commented Jun 1, 2021

Potential validation oversight - @skip/@include; see related RFC: graphql/graphql-spec/pull/860
ACTION - Benjie - raise a separate PR for this against GraphQL.js

Note: Action Item issues are reviewed and closed during Working Group
meetings.
@benjie benjie added this to To do in Actions 2021-05-13 via automation Jun 1, 2021
@benjie benjie self-assigned this Jun 1, 2021
@benjie benjie added this to To do in Actions 2021-09-02 via automation Nov 28, 2021
@benjie
Copy link
Member Author

benjie commented Nov 28, 2021

From https://github.com/graphql/graphql-wg/blob/main/notes/2021-09-02.md#review-previous-meetings-action-items-5m-lee

Ivan: I can do this Benjie, ping me
[ACTION - Benjie] Ping Ivan about this

@IvanGoncharov PING! 😁

@benjie
Copy link
Member Author

benjie commented Jan 6, 2022

@IvanGoncharov Did you get a chance to look at this?

@benjie benjie added the Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings. label Oct 9, 2023
@benjie benjie mentioned this issue Oct 9, 2023
Open
@benjie
Copy link
Member Author

benjie commented Oct 9, 2023

I've raised a PR with a basic implementation: graphql/graphql-js#3974

@benjie benjie closed this as completed Dec 7, 2023
Actions 2021-05-13 automation moved this from To do to Done Dec 7, 2023
Actions 2021-09-02 automation moved this from To do to Done Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjie benjie

Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
Actions 2021-05-13
  
Done
Actions 2021-09-02
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjie @IvanGoncharov