Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2021-07-01] Everyone: review spec text changes for argument uniqueness RFC #794

Closed
benjie opened this issue Nov 28, 2021 · 2 comments
Closed

[2021-07-01] Everyone: review spec text changes for argument uniqueness RFC #794

benjie opened this issue Nov 28, 2021 · 2 comments
Assignees
@IvanGoncharov
Labels
Action item 🎬 Everyone 🌐 Need everyone to look at this Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
Actions 2021-07-01

Comments

@benjie
Copy link
Member

benjie commented Nov 28, 2021

Benjie: We don’t have a rule in the spec that says arguments have to be unique. I’ve looked over the spec and it’s a very small change, which adds a constraint in three places.
Lee: <advances RFC to stage 1>
ACTION - everyone - review on the spec text and the changes.

Note: Action Item issues are reviewed and closed during Working Group
meetings.
@benjie benjie added this to To do in Actions 2021-07-01 via automation Nov 28, 2021
@benjie
Copy link
Member Author

benjie commented Nov 28, 2021

@IvanGoncharov Do you want to add "ready for review" label to this?

@benjie benjie added the Everyone 🌐 Need everyone to look at this label Nov 28, 2021
@benjie
Copy link
Member Author

benjie commented Oct 9, 2023

The associated PR was closed in favour of graphql/graphql-spec#891 which has been merged; as has the GraphQL-js PR: graphql/graphql-js#3208

This has been addressed.

@benjie benjie added the Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings. label Oct 9, 2023
@benjie benjie closed this as completed Oct 9, 2023
Actions 2021-07-01 automation moved this from To do to Done Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvanGoncharov IvanGoncharov

Labels
Action item 🎬 Everyone 🌐 Need everyone to look at this Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
No open projects
Actions 2021-07-01
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjie @IvanGoncharov