Update the account screen loading state #41481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't show state pills until MFA devices are loaded - Actually show the spinner on the passkey list - Fix the test flakiness
bl-nero
added
no-changelog
kimlisa
approved these changes
May 14, 2024
Comment on lines
+367
to
+376
| <RelativeBox> | ||
| {fetchDevicesAttempt.status === 'processing' && ( | ||
| // This trick allows us to maintain center alignment of the button | ||
| // and display it along with the indicator. | ||
| <BoxToTheRight mr={3} data-testid="indicator-wrapper"> | ||
| <Indicator size={40} /> | ||
| </BoxToTheRight> | ||
| )} | ||
| {button} | ||
| </RelativeBox> |
There was a problem hiding this comment.
is this how we are going to display spinners for buttons now? i always thought the spinner be inside the button but 🤷♀️
There was a problem hiding this comment.
I think that a spinner inside a button is supposed to indicate that an operation performed by the button is pending. In this case, we are talking about a loading operation that triggers the button's availability.
|
One thing to note: This PR requires https://github.com/gravitational/teleport.e/pull/4128 to be merged first. |
ravicious
approved these changes
May 14, 2024
public-teleport-github-review-bot
bot
removed the request for review
from ibeckermayer
|
Tested: loading the account settings screen with network throttling in the following scenarios:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41402