You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We recently published a really nice example of how far we can take this feature: https://www.youtube.com/watch?v=vKYEFpO06Tk
There were 3 reasons we originally shipped this part of Skia instead of using this module:
We wanted to avoid the image encoding step (but I see that now there is a "raw" option).
We have a way to return the bitmap data via JSI without doing a bridge roundtrip (a bit simpler than using the filesystem but we could discuss it).
We had control for fast bug fixes.
But I'm wondering if we should maybe do some alignments. Maybe we could improve on all fronts. I see that this feature is heavily featured/documented on Expo side (@brentvatne@Kudo)
The text was updated successfully, but these errors were encountered:
@gre@cortinico I see that this module is still active, we fixed tons of bugs in our implementation since this issue was file and we also test it end-to-end. I'm really wondering if there is some alignment/code sharing we could do there
Our original implementation of view snapshots is based on this module.
We fixed quite a big of bugs since on Android (to respect transforms/opacity/ and z-index): https://github.com/Shopify/react-native-skia/blob/main/package/android/src/main/java/com/shopify/reactnative/skia/ViewScreenshotService.java
We recently published a really nice example of how far we can take this feature: https://www.youtube.com/watch?v=vKYEFpO06Tk
There were 3 reasons we originally shipped this part of Skia instead of using this module:
But I'm wondering if we should maybe do some alignments. Maybe we could improve on all fronts. I see that this feature is heavily featured/documented on Expo side (@brentvatne @Kudo)
The text was updated successfully, but these errors were encountered: