-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Expectation type expect_column_values_to_match_regex fails for databricks-sqlalchemy #9546
Comments
As GX team is not accepting pull requests, I am providing the fix here. The code block is exactly same as that of snowflake. The check for databricks is using dialect.name. May be there is better approach for this check which I am not aware. File Name: great_expectations/expectations/metrics/util.py
|
One of my test developers also has this problem; we are using databricks extensively in our company, and hoped to use this to automate much of the testing. Although it's a small thing to do some polymorphism, overriding, or just good old fashioned works-on-my-machine changes, it would be best for us not to have to maintain additional code behind a specific version of the library. @Kilo59 is there any ability to re-vist an MR/PR for this? This has merit and certainly impacts test driven organizations using databricks as a primary hub for storage, access, and datalake aggregation. @satniks Thanks for the write up! |
@immerautumn @satniks However, as far as I know, we are still accepting pull requests. |
…or databricks-sqlalchemy Added support for databricks-sqlalchemy for the regular expression based expectation expect_column_values_to_match_regex Please check the corresponding issue great-expectations#9546
@immerautumn , submitted the PR @Kilo59 , the contribute section of the README file says "We’re temporarily pausing the acceptance of new pull requests (PRs)." and therefore I did not create the PR. |
@Kilo59 , any plan to fix this issue (using this pull request or any other way) for v1.0? |
We are using latest GX (v 0.18.10) with databricks based on python packages sqlalchemy-databricks and databricks-sql-connector.
All our GX rules which worked fine with databricks/sqlalchemy except the rule for regular expression. We get following error in the validation result indicating there is no support for databricks for regex rules using sqlalchemy.
"Regex is not supported for dialect {_dialect.dialect.name!s}
"\nAttributeError: 'DatabricksDialect' object has no attribute 'dialect'
The text was updated successfully, but these errors were encountered: