Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False failure produces "breaking the build" pull request #1120

Open
phts opened this issue Jul 21, 2019 · 1 comment
Open

False failure produces "breaking the build" pull request #1120

phts opened this issue Jul 21, 2019 · 1 comment

Comments

@phts
Copy link

phts commented Jul 21, 2019

My repo's CI uses npm ci to install dependencies.

greenkeeper checks package new version by changing only package.json and keeps package-lock.json out-of-sync with package.json. In this case npm ci fails due to

cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.

and produces "breaking the build" pull requests which is not relevant.

Example:

@coderbyheart
Copy link

According to this blogpost Greenkeeper has built-in support for updating lockfiles.

And I do see that GK does update the lockfile most of the time, but for some reasons, some tests with updated dependencies are not getting their lockfiles updates.

Working example: bifravst/athena-helpers#14
Broken example in the same repo: bifravst/athena-helpers#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants