Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support jsxRuntime #613

Merged
merged 1 commit into from Nov 1, 2021
Merged

feat: support jsxRuntime #613

merged 1 commit into from Nov 1, 2021

Conversation

gregberge
Copy link
Owner

It default to "classic", the old behaviour. But it can be "automatic" (the recommended) or "classic-preact".

It default to "classic", the old behaviour. But it can be "automatic" (the recommended) or "classic-preact".
@vercel
Copy link

vercel bot commented Nov 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gregberge/svgr/9CDsZQ31j8g8fCTVd4vPbkC1qUeU
✅ Preview: https://svgr-git-jsx-runtime-gregberge.vercel.app

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #613 (8484497) into main (bbf0430) will decrease coverage by 0.13%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
- Coverage   89.75%   89.62%   -0.14%     
==========================================
  Files          32       32              
  Lines         664      694      +30     
  Branches      212      225      +13     
==========================================
+ Hits          596      622      +26     
- Misses         67       71       +4     
  Partials        1        1              
Impacted Files Coverage Δ
packages/core/src/config.ts 100.00% <ø> (ø)
packages/plugin-jsx/src/index.ts 81.81% <76.92%> (-7.08%) ⬇️
...el-plugin-transform-svg-component/src/variables.ts 98.90% <95.45%> (-1.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf0430...8484497. Read the comment docs.

@gregberge gregberge merged commit 3700aba into main Nov 1, 2021
@gregberge gregberge deleted the jsx-runtime branch November 1, 2021 07:39
@xobotyi
Copy link

xobotyi commented Nov 3, 2021

@gregberge hey!
Just wonder when this commit is planned to be published.

@gregberge
Copy link
Owner Author

@gregberge hey!
Just wonder when this commit is planned to be published.

Hey, will be part of the next alpha, probably this week-end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants