fix(cli): pass in parser to prettier format to avoid deprecation warning #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/gregberge/svgr/C9HyWFMP1e57K2tVNPM9rMfc1Nxt |
gregberge
requested changes
Jan 9, 2022
packages/cli/src/dirCommand.ts
Outdated
Comment on lines
100
to
103
| const prettierRcConfig = opts.runtimeConfig | ||
| ? await resolveConfig(filepath, { editorconfig: true }) | ||
| : {} | ||
| const prettierFileInfo = await getFileInfo(filepath) |
There was a problem hiding this comment.
Did some more digging in the prettier source code. getFileInfo ends up using resolveConfig again and inferring based on filepath. So to avoid extra work (and extra IO) it's better to just pass in file path as an option. Updated the code and verified by running the CLI.
mikaelbr
force-pushed
the
explicit-parser-prettier-format
branch
from
0734f69
to
36515ba
Compare
mikaelbr
force-pushed
the
explicit-parser-prettier-format
branch
from
36515ba
to
9f93734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prettier now gives warning when not being able to infer correct parser for files. It can infer by checking filepath or when explicitly setting parser. See issue and comment: prettier/prettier#4763 (comment)
This causes outputs such as:
There are different ways to solve this:
In this PR I've chosen the latter option as it feels more explicit. In plugin-prettier it is hardcoded to babel but as I see it that might not be correct here?
Test plan
Tested by running and verifying that prettier deprecation warning is gone.