feat(descProp): add descProp option #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi, @gregberge . This PR has been here for a while and I have yet to get a review. Is there someone I should message to get a review? |
gregberge
approved these changes
Jun 19, 2022
|
@Aveline-art thanks for your work on this! |
This was referenced Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #714
babel-plugin-svg-dynamic-titleto add a descProptagoption indicating the attribute/element to add to the svg ('title' for title, or 'desc' for desc)babel-plugin-transform-svg-componentto add additional desc and descId attributes to the svg if descProp is truebabel-presetto add thearia-describedbyattributeTest plan
Simply
npm run test! Existing tests have been slightly modified. New tests have been added to test the new feature.