Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override does not work for --no-index (and maybe others) #736

Closed
gregberge opened this issue Jun 19, 2022 · 6 comments
Closed

Override does not work for --no-index (and maybe others) #736

gregberge opened this issue Jun 19, 2022 · 6 comments

Comments

@gregberge
Copy link
Owner

馃悰 Bug Report

Originally reported from #607 (comment)

@gregberge FYI this option in the API override does not seem to work, I had to add it to the CLI command I am running to disable the generation. I tried index: true and index: false and it had no impact and an index was still being generated. And also, the reason why I tried both is because its not immediately easy to figure out, due to the wording and the name of the option, to know which actually turns it off. I'd suggest renaming the API override to noIndex as well so that you know setting it to true disables index generation. index: true implies an index WILL be created.

@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 1, 2022
@DZakh
Copy link

DZakh commented Oct 3, 2022

I've come across the issue too, will use cli option --no-index for now

@stale stale bot removed the wontfix label Oct 3, 2022
@DZakh
Copy link

DZakh commented Oct 3, 2022

The same problem exists for the dimentions option too. Which is a regression from version 5.

@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 21, 2023
@ahockersten
Copy link

I think this was fixed recently, probably by #845 ? In any case, with SVGR 8.1.0, setting index: false means an index will get generated. This was not the case for me in SVGR 8.0.1.

@stale stale bot removed the wontfix label Aug 29, 2023
@gregberge
Copy link
Owner Author

Let's close it then, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants