Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Failed prop type: Material-UI: you are using a deprecated typography variant: subheading that will be removed in the next major release. #354

Open
jkeruzec opened this issue Jan 7, 2019 · 8 comments

Comments

@jkeruzec
Copy link
Contributor

jkeruzec commented Jan 7, 2019

Please upgrade material-ui typography variant to latest version.

Thanks :)

@gregnb
Copy link
Owner

gregnb commented Jan 7, 2019

It'll be done tonight

@mking42
Copy link

mking42 commented Jan 9, 2019

Duplicate of: #333

@aishmit
Copy link

aishmit commented Jan 15, 2019

I seem to be getting same error, running the latest version of material-ui/core and latest version of mui-datatables

When i expand the error it points towards getMuiTheme()
image

@jkeruzec
Copy link
Contributor Author

FYI, Material UI is preparing a version V4 with removal of deprecated behaviour.

mui/material-ui#13663

@gregnb
Copy link
Owner

gregnb commented Jan 25, 2019

This issue has been resolved in beta-53. Please let me know if there are any further problems

@foxmicha
Copy link

Still receiving this issue in 2.0.0-beta-53:

image

Code in question:

getMuiTheme = () => createMuiTheme({
        overrides: {
            //@ts-ignore
            MUIDataTableBodyCell: {
                root: {
                    padding: "4px"
                }
            },
            MUIDataTableHeadCell: {
                root: {
                    padding: "4px"
                }
            }
        }
    })

    render() {
        return (
            <>
            <MuiThemeProvider theme={this.getMuiTheme()}>
                <MUIDataTable
                    title={"DataTable Demo"}
                    data={randomData}
                    columns={muiDataTableColumns}
                    options={options}
                />
            </MuiThemeProvider>
            </>
        );
    }

@gregnb
Copy link
Owner

gregnb commented Jan 27, 2019

@foxmicha Can you provide your environment information? mui ver, etc

@foxmicha
Copy link

material-ui/core: 3.7.1
material-ui/icons: 3.0.2
mui-datatables: 2.0.0-beta-53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants