Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDs are not unique - Violation of SIA-R3 #1406

Open
alvaropmontenegro opened this issue Dec 15, 2023 · 1 comment
Open

IDs are not unique - Violation of SIA-R3 #1406

alvaropmontenegro opened this issue Dec 15, 2023 · 1 comment
Labels
wontfix This will not be worked on

Comments

@alvaropmontenegro
Copy link

Hi! I've recently been analyzing the Container.tsx code, and I noticed a potential issue related to duplicate IDs that may impact accessibility. In the Container component, there's a static ID, "gridjs-temp" associated with a div element:

<div ref={tempRef} id="gridjs-temp" className={className('temp')} />

The use of static IDs can result in duplicate IDs if the Container component is used multiple times on the same page (this is happening in one of my projects). This situation violates the accessibility guideline SIA-R3, which recommends that element IDs should be unique.

To address this concern, I suggest making the ID dynamic or generating it dynamically to ensure uniqueness. One approach is to append a unique identifier based on some context or a counter.

If you have any questions or need further clarification, feel free to reach out. Thank you.

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant