Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty translated fields fallback to default language. #1418

Open
rubycon opened this issue Feb 1, 2024 · 0 comments
Open

Empty translated fields fallback to default language. #1418

rubycon opened this issue Feb 1, 2024 · 0 comments

Comments

@rubycon
Copy link

rubycon commented Feb 1, 2024

Describe the bug
Empty translated fields fallback to default language.

To Reproduce
Setup a paginated table with FR translation and you'll see something like :

Affichage des résultats 1 à 6 sur 6 results

Expected behavior
It should display :

Affichage des résultats 1 à 6 sur 6.

Additional context
The issue comes from here :

if (translated) {

The french translation file translate results as an empty string to compensate issues with the word basis translation but the translation function fallback to the default language when dealing with an empty string.

Usually its the right behaviour for a translation system but here it conflicts with the hacky way the translation is handled.

See issue #1416 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant