Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text selection impossible on top of titles #191

Open
cyrilf opened this issue Jun 2, 2019 · 1 comment
Open

Text selection impossible on top of titles #191

cyrilf opened this issue Jun 2, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@cyrilf
Copy link

cyrilf commented Jun 2, 2019

All the h1, h2 and h3 have a positive padding-top and a negative margin-top like:

h1, h2, h3 {
padding-top: 6rem;
margin-top: -5rem;

Because of this negative margin-top the text above any title can't be selected (in the green area):

Screenshot from 2019-06-02 20-38-44


Solution

Can't we just do something like:

h1, h2, h3 {
  margin-top: 6rem;
}

If yes, I'm happy to open a PR.
Otherwise I'm curious about the usage of a negative margin/positive padding in this case?

@cyrilf cyrilf changed the title Titles padding-top block text selection Text selection impossible on top of titles Jun 2, 2019
@robaxelsen robaxelsen added the bug Something isn't working label Jun 2, 2019
@dmtrshat
Copy link

I solved this problem, but ... can you add my pool request and then I will create a new one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants