Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docs menu collapse functionality #532

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Dana94
Copy link
Contributor

@Dana94 Dana94 commented Oct 3, 2020

I created a new component called DocsMenu to store each collapsible section of the menu.

Arrow svg from : https://www.freeicons.io/material-icons-navigation-2/arrow-back-ios-icon-16675

closes #514

feat: hide border for first menu section


clean-up
@tomtev
Copy link
Member

tomtev commented Oct 5, 2020

Love this! We should maybe try to store in local storage what sections that have been opened and closed? So when you refresh it stays the same.

@Dana94
Copy link
Contributor Author

Dana94 commented Oct 5, 2020

Sure, I can do this. 👍

@hjvedvik
Copy link
Member

It seems to work very well! I just noticed that the arrows were a little hard to see in dark mode.

@Dana94
Copy link
Contributor Author

Dana94 commented Oct 30, 2020

Right, I'll fix that!

@Dana94
Copy link
Contributor Author

Dana94 commented Oct 30, 2020

I don't see the icon for changing to dark/mocha/light mode in my branch so I checked out Master and it wasn't there either. 😕

@TerabyteTiger
Copy link
Member

Not to bring this up a year later, but can you use the CSS variable --body-color to fill the svg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu sidebar collapsed
4 participants