From 26e4d57265eaa9fc121295322b1c7eacfe1bc8d0 Mon Sep 17 00:00:00 2001 From: DevineLiu <23489096+DevineLiu@users.noreply.github.com> Date: Wed, 15 Aug 2018 20:56:24 +0800 Subject: [PATCH] repair urllib3 can't set timeout! (#6286) cls._timeout should be transfer to request when init urllib3.PoolManager --- py/selenium/webdriver/remote/remote_connection.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/py/selenium/webdriver/remote/remote_connection.py b/py/selenium/webdriver/remote/remote_connection.py index 12abf126f9454..1dcc2e12883d6 100644 --- a/py/selenium/webdriver/remote/remote_connection.py +++ b/py/selenium/webdriver/remote/remote_connection.py @@ -137,7 +137,7 @@ def __init__(self, remote_server_addr, keep_alive=False, resolve_ip=True): self._url = remote_server_addr if keep_alive: - self._conn = urllib3.PoolManager() + self._conn = urllib3.PoolManager(timeout=self._timeout) self._commands = { Command.STATUS: ('GET', '/status'), @@ -398,7 +398,7 @@ def _request(self, method, url, body=None): statuscode = resp.status else: - http = urllib3.PoolManager() + http = urllib3.PoolManager(timeout=self._timeout) resp = http.request(method, url, body=body, headers=headers) statuscode = resp.status