Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print undercover result to a file #113

Open
rafayet-monon opened this issue Oct 19, 2020 · 2 comments
Open

Print undercover result to a file #113

rafayet-monon opened this issue Oct 19, 2020 · 2 comments

Comments

@rafayet-monon
Copy link

I was trying to use the Undercover gem with Danger. For the Danger to read data from undercover, the report was needed to be printed in a file.

Is it possible to add a -o $output_path option within undercover which can be super useful for a lot of people out there?

@grodowski
Copy link
Owner

Hi @rafayet-monon! Thanks for submitting this issue and most importantly for your work on https://github.com/nimblehq/danger-undercover. Just added a link to it in the readme file.

Adding a file output option is surely welcome. My concern is mostly about the specific output format and how it's going to be consumed (e.g. should it be JSON or something else). I don't know much about the internals of danger (as a user of pronto), but it would be nice to have stuff like inline comments and this could already warrant some structured output. Not going to work on this immediately, but I'd be happy to discuss more details here

@rafayet-monon
Copy link
Author

For danger-undercover, we just used the output the undercover provides. What we did was print it in a .txt file and show it in PR. It was just simple and straightforward.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants