update @eslint airbnb

[britt6612]

update eslint and eslint-config-airbnb for grommet

[britt6612]

When updating to the latest @airbnb eslint package we get over 1500 errors this is all mostly caused by a new rule that was changed from "off" to "error" in the latest release. This was not documented within the release notes so I had to dig a little to find the change.

I did find another issue though documenting the same problems we are running into here airbnb/javascript#2505

There is an open PR for this issue that was opened about a month ago airbnb/javascript#2501

In this PR you can see where the rule got changed

We can either upgrade and turn this rule "off" and keep track of the progress in the airbnb repo or we can wait to upgrade until it is resolved. Locally I did turn off the rule and I have about 49 errors which is much more reasonable to go through and see the changes..

@ericsoderberghp I'm leaning towards turning this rule off for now and moving forward with an update but would like your opinion as well.

[ericsoderberghp]

Agreed. Let's turn it off for now, with a comment where we do that referring to this issue.

[britt6612]

Agreed. Let's turn it off for now, with a comment where we do that referring to this issue.

sounds good I'll get to it!

[MikeKingdom]

Same here. That's an annoying default. I wonder if it would go better if we changed it to only enforce what we seem to prefer like arrow-function for named and unnamed components? Not sure all which styles we use.

[britt6612]

Same here. That's an annoying default. I wonder if it would go better if we changed it to only enforce what we seem to prefer like arrow-function for named and unnamed components? Not sure all which styles we use.

I can look into something like this I believe for the most part we are using arrow-functions but with this rule it did not like the arrow-function it was wanting me to put back the function so seemed like we were regressing..