Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Move metautils to it's own package #392

Closed
bwplotka opened this issue Jan 30, 2021 · 9 comments
Closed

v2: Move metautils to it's own package #392

bwplotka opened this issue Jan 30, 2021 · 9 comments
Assignees

Comments

@bwplotka
Copy link
Collaborator

This is the package that allows to pass things across gRPC peers. You mention @johanbrandhorst some other methods for this 馃 Is there something or should we maintain it here?

@johanbrandhorst
Copy link
Collaborator

I think this is written on top of gRPC metadata? It should still be relevant in that case.

@bwplotka
Copy link
Collaborator Author

bwplotka commented Jan 30, 2021

It is indeed.

Cool, let's move it out of utils then!

@gunadhya
Copy link

Hi @bwplotka and @johanbrandhorst, I'd like to work on this issue. Just to confirm the metautils needs to be moved outside utils to the root and the references need to be updated right?

@bwplotka
Copy link
Collaborator Author

Correct, just while you are doing this, can you just double check if all method names, comments make sense too? Would be nice to clean this before v2 release (while we can) 馃

Also some better package name might be needed. The metadata is the original name on gRPC package that this one wraps. niceMD is not the best name as .... what nice means? Let's be more focused. Some name that exactly tells what it's added on top of original metadata package would be amazing (don't have idea right now). Feel free to propose something in the PR @gunadhya 馃

Thanks!

@bwplotka
Copy link
Collaborator Author

bwplotka commented Jan 31, 2021

Oh, and make sure you to start from v2 branch and you point your PR to v2 (it has to be done manually for now on GitHub UI)

@gunadhya
Copy link

gunadhya commented Feb 1, 2021

Some changes to metautils were made since v2 got created as shown here -> master and v2
I found this and was just wondering if git checkout master -- dirname is the right way to update the package files or is there a better way to do this?

@yashrsharma44
Copy link
Collaborator

yashrsharma44 commented Apr 26, 2021

You need to rebase your branch and start working on top of the current changes.
More info on rebasing - https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase

@bwplotka bwplotka added this to To do in Milestone v2 Aug 6, 2021
@bwplotka bwplotka assigned yashrsharma44 and unassigned gunadhya Aug 6, 2021
@rahulkhairwar
Copy link
Contributor

rahulkhairwar commented Nov 22, 2021

Hi @bwplotka , as the issue has been idle for a while, I've raised a PR for this change.

Please have a look and let me know if there are any suggested changes.

rahulkhairwar added a commit to rahulkhairwar/go-grpc-middleware that referenced this issue Dec 1, 2021
- Move util/metautils to root-level package metadata
- Rename NiceMD to MD, which is a wrapper for grpc/metadata.MD
rahulkhairwar added a commit to rahulkhairwar/go-grpc-middleware that referenced this issue Dec 5, 2021
- Move util/metautils to root-level package metadata
- Rename NiceMD to MD, which is a wrapper for grpc/metadata.MD
@bwplotka
Copy link
Collaborator Author

Fixed by #474

Milestone v2 automation moved this from To do to Done Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants