Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to verify the tool version when installed with go install #3321

Open
roarc0 opened this issue May 24, 2023 · 1 comment
Open

Unable to verify the tool version when installed with go install #3321

roarc0 opened this issue May 24, 2023 · 1 comment

Comments

@roarc0
Copy link

roarc0 commented May 24, 2023

馃悰 Bug Report

Installing the tool with go install installs a binary that is not capable of reporting the version.

To Reproduce

  1. go install github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-grpc-gateway@v2.15.2
  2. protoc-gen-grpc-gateway --version

Expected behavior

Version v2.15.2, commit xxxx, built at xxxx

Actual Behavior

Version dev, commit unknown, built at unknown

@johanbrandhorst
Copy link
Collaborator

I don't know if it's possible to make this work the way we do it today, since the version is passed into the binary at build time. We'd have to store a constant in the Go files instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants