Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestOutgoingTrailerMatcher is non-deterministic #4264

Closed
joshgarnett opened this issue Apr 27, 2024 · 0 comments · Fixed by #4265
Closed

TestOutgoingTrailerMatcher is non-deterministic #4264

joshgarnett opened this issue Apr 27, 2024 · 0 comments · Fixed by #4265

Comments

@joshgarnett
Copy link
Contributor

PR #4259 added comparing the headers in TestOutgoingTrailerMatcher. While working on another PR, I noticed that this would sometimes fail when the github hooks run the tests. This is caused by the TrailerMD being a map, which has a non-deterministic read order. A simple fix is to just sort the headers received before comparing.

I'll create a PR shortly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing TestOutgoingTrailerMatcher, which was non-deterministic joshgarnett/grpc-gateway
1 participant
@joshgarnett