Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock stream #1230

Merged
merged 3 commits into from
May 19, 2017
Merged

Mock stream #1230

merged 3 commits into from
May 19, 2017
+326 −1

Conversation

MakMukhi
Copy link
Contributor

Fixes #1226

@MakMukhi MakMukhi requested review from dfawley and menghanl May 10, 2017 23:34
menghanl
menghanl reviewed May 16, 2017
View reviewed changes
examples/route_guide/mock_routeguide/rg_mock_test.go
gomock.Any(),
).Return(nil)
// Set expectation on receiving.
stream.EXPECT().Recv().Return(msg, nil)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of returning the same msg every time, is it possible to store the message sent by last Send() and return it here?

@menghanl menghanl merged commit 074dbfb into grpc:master May 19, 2017
@menghanl menghanl added 1.4 Type: Documentation Documentation or examples labels Jun 7, 2017
@MakMukhi MakMukhi deleted the mock_stream branch May 4, 2018 02:08
@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl

@dfawley dfawley

Assignees

@menghanl menghanl

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MakMukhi @menghanl