Any news on client interceptors becoming stable?

[phil-f]

grpc-go/interceptor.go

Line 31 in 04ea820

type UnaryClientInterceptor func(ctx context.Context, method string, req, reply interface{}, cc *ClientConn, invoker UnaryInvoker, opts ...CallOption) error

grpc-go/interceptor.go

Line 39 in 04ea820

type StreamClientInterceptor func(ctx context.Context, desc *StreamDesc, cc *ClientConn, method string, streamer Streamer, opts ...CallOption) (ClientStream, error)

As the title says, these extremely useful pieces of functionality have been labelled as experimental for a while.

Would be nice to hear if there's any news on them becoming stable as using outgoing middleware in prod would be great :). If there's another way to implement outgoing middleware that isn't experimental then pointers to that would be much appreciated.

[dfawley]

My guess is, at this point, enough people are using it that it would be extremely difficult to change, even though it's technically allowed by our versioning policy. Also, some interceptors are experimental and some are not, probably due to an oversight before GA. We can go ahead and call these "stable".

[phil-f]

ah that's great news! thanks for the info :)

[dfawley]

Let's leave this open to cover making them stable.

[hypnoglow]

Hi!

What needs to be done to close this issue? Is it just removing comments about experimental API or anything else?

Thanks

[dfawley]

In addition to removing the "experimental" comments, we should improve their documentation comments a bit -- e.g. what the parameters/return values are, when they are called, etc.

[hypnoglow]

@dfawley I opened #3948

I added additional commentary on parameters and return values etc. as far as I understand them. Please let me know if we need to rephrase/add/remove something in those comments.

[hypnoglow]

@dfawley As the PR with updates to documentation is merged, I think this issue can be closed.

[dfawley]

That's right, thanks for following up.