Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: cleanup README.md #3738

Merged
merged 3 commits into from Jul 14, 2020
Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jul 10, 2020

  • Drop outdated text
  • Retain what is unique to this page
  • Refer reader to the quick start page for the rest

Contributes to grpc/grpc.io#180

@dfawley /cc @ejona86 @jtattermusch

- Drop outdated text
- Retain what is unique to this page
- Refer reader to the quick start page for the rest

Contributes to grpc/grpc.io#180
@chalin
Copy link
Contributor Author

chalin commented Jul 10, 2020

This PR has two commits for two variants of changes to this README -- you can view each commit separately.

The second commit drops the "set PATH" step, step 1.
Let me know which variant you prefer.

(I'm trying to keep these instructions as simple as possible, referring the adventurous developer to the Quick Start page for extra information 😄)

examples/README.md Outdated Show resolved Hide resolved
@dfawley dfawley changed the title examples/README cleanup examples: cleanup README.md Jul 10, 2020
@dfawley dfawley added the Type: Documentation Documentation or examples label Jul 11, 2020
@dfawley dfawley added this to the 1.31 Release milestone Jul 11, 2020
@chalin
Copy link
Contributor Author

chalin commented Jul 13, 2020

Thanks @dfawley. Anything left to do before this is merged?

@dfawley dfawley merged commit a6c3c69 into grpc:master Jul 14, 2020
@chalin chalin deleted the chalin-ex-readme-200710 branch July 15, 2020 16:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants