xds: add LRS balancing policy #3799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
reviewed
Aug 10, 2020
| select { | ||
| case <-time.After(time.Second): | ||
| return nil, fmt.Errorf("timeout") | ||
| case a := <-xdsC.loadReportCh: |
There was a problem hiding this comment.
Why not make this loadReportCh of type testutils.Channel which provides a timed receive operation?
There was a problem hiding this comment.
Because it cannot import testutils..
There was a problem hiding this comment.
Hmm .... I thought it only cannot import the fakeclient package which imports lrs. But testutils package shouldn't have a dependency on lrs.
There was a problem hiding this comment.
Yes.
It is because xds-client takes lrs.Store as an input. It should be refactored to own the lrs.Store. And after that, this dependency will be gone.
easwars
approved these changes
Aug 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LB config as in https://github.com/grpc/grpc-proto/blob/master/grpc/service_config/service_config.proto#L292