server: Add ServiceRegistrar interface. #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
added
no release notes
Type: API Change
dfawley
reviewed
Aug 14, 2020
server.go
Outdated
Comment on lines
546
to
547
| // | ||
| // This API is EXPERIMENTAL. |
There was a problem hiding this comment.
This can't be experimental if we use it in stable generated code.
server.go
Outdated
Comment on lines
549
to
551
| // RegisterService registers a service and its implementation to the | ||
| // concrete type implementing this interface. It is called from the IDL | ||
| // generated code. |
There was a problem hiding this comment.
// RegisterService registers a service and its implementation to the
// concrete type implementing this interface. It may not be called
// once the server has started serving.(I think we can omit the bit about generated code here.)
server.go
Outdated
| // generated code. | ||
| // | ||
| // This API is EXPERIMENTAL. | ||
| RegisterService(*ServiceDesc, interface{}) |
There was a problem hiding this comment.
Name these parameters:
desc *ServiceDesc, impl interface{}
And document them above:
// desc describes the service and its methods and handlers. impl is the service
// implementation which is passed to the method handers*.* - for some reason we can't explain.
dfawley
approved these changes
Aug 14, 2020
|
Sorry, I missed a thing. You need to add a https://github.com/grpc/grpc-go/blob/master/rpc_util.go#L879 Technically it isn't actually necessary, but it does give a better signal that the user is using too old a version of grpc-go vs. "doesn't compile because of some random undefined symbol". |
easwars
added a commit
to easwars/grpc-go
that referenced
this pull request
Aug 14, 2020
This was missed out in grpc#3816.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.