Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/transport: handle h2 errcode on header decoding #3872

Merged
merged 1 commit into from Sep 17, 2020

Conversation

tz70s
Copy link
Contributor

@tz70s tz70s commented Sep 13, 2020

Handles HTTP2 error code when malformed request/response
header appears.

Fixes: #3819


This change is Reviewable

@tz70s tz70s closed this Sep 13, 2020
@tz70s tz70s reopened this Sep 13, 2020
@tz70s tz70s force-pushed the handle-malformed-reqresp-h2-code branch from 50a3a26 to 91f8415 Compare September 13, 2020 09:39
internal/transport/http_util_test.go Show resolved Hide resolved
internal/transport/http_util_test.go Outdated Show resolved Hide resolved
internal/transport/http_util_test.go Outdated Show resolved Hide resolved
internal/transport/http_util_test.go Outdated Show resolved Hide resolved
internal/transport/http_util_test.go Outdated Show resolved Hide resolved
internal/transport/http2_server.go Show resolved Hide resolved
Handles HTTP2 error code when malformed request/response
header appears.

Fixes: grpc#3819
@tz70s tz70s force-pushed the handle-malformed-reqresp-h2-code branch from 91f8415 to 8802e23 Compare September 17, 2020 00:02
@easwars easwars added this to the 1.33 Release milestone Sep 17, 2020
Copy link
Contributor

@easwars easwars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR.

@easwars easwars merged commit bf9584e into grpc:master Sep 17, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server reports INTERNAL_ERROR on malformed requests
3 participants