Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connectivity: remove unused, experimental Reporter interface #3875

Merged
merged 1 commit into from Sep 14, 2020
Merged

connectivity: remove unused, experimental Reporter interface #3875

merged 1 commit into from Sep 14, 2020

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Sep 14, 2020

No description provided.

@easwars easwars added the Type: API Change Breaking API changes (experimental APIs only!) label Sep 14, 2020
@easwars easwars added this to the 1.33 Release milestone Sep 14, 2020
@dfawley dfawley changed the title connectivity: Get rid of unused Reporter interface. connectivity: Remove unused, experimental Reporter interface Sep 14, 2020
dfawley
dfawley approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added "experimental" to your PR title to stress that this is not in violation of our versioning policy.

@easwars
Copy link
Contributor Author

easwars commented Sep 14, 2020

I added "experimental" to your PR title to stress that this is not in violation of our versioning policy.

Thank you :)

@easwars easwars merged commit 86d33e4 into grpc:master Sep 14, 2020
@easwars easwars deleted the connectivity branch September 14, 2020 23:53
@menghanl menghanl changed the title connectivity: Remove unused, experimental Reporter interface connectivity: remove unused, experimental Reporter interface Sep 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@menghanl menghanl Awaiting requested review from menghanl

Assignees

@menghanl menghanl

Labels
Type: API Change Breaking API changes (experimental APIs only!)
Projects
None yet
Milestone
1.33 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@easwars @dfawley @menghanl