Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binarylog: how to use? #3878

Closed
vaddenz opened this issue Sep 15, 2020 · 4 comments · Fixed by #3879
Closed

binarylog: how to use? #3878

vaddenz opened this issue Sep 15, 2020 · 4 comments · Fixed by #3879
Labels
Type: Question

Comments

@vaddenz
Copy link

vaddenz commented Sep 15, 2020

For now binarylog is internal package, everything we need (Sink interface, SetDefaultSink method) can not be accessed. So how to use it?
@menghanl
Copy link
Contributor

It's controlled by env variables. See https://github.com/grpc/proposal/blob/master/A16-binary-logging.md#control-interface

@vaddenz
Copy link
Author

vaddenz commented Sep 15, 2020

You didn't get it.

The config can only turn on this feature, but log to NOOP sink. Thers is no way to configure the Logger/Sink, or implementing new Sinks.

@menghanl menghanl reopened this Sep 15, 2020
@menghanl menghanl mentioned this issue Sep 15, 2020
Merged
@menghanl
Copy link
Contributor

Sorry. You are right.
This should be fixed by #3879. Please take a look.

@vaddenz
Copy link
Author

vaddenz commented Sep 16, 2020

Thx, lightspeed!

@vaddenz vaddenz closed this as completed Sep 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Type: Question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

binarylog: export Sink menghanl/grpc-go
2 participants
@menghanl @vaddenz