grpclb: consider IDLE SubConns as connecting #4031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, when the first response is received from the grpclb server, the parent ClientConn enters TransientFailure, and the first several non-wait-for-ready RPCs will fail.
| @@ -298,7 +298,7 @@ func (lb *lbBalancer) aggregateSubConnStates() connectivity.State { | |||
| switch state { | |||
| case connectivity.Ready: | |||
| return connectivity.Ready | |||
| case connectivity.Connecting: | |||
| case connectivity.Connecting, connectivity.Idle: | |||
There was a problem hiding this comment.
Can you also update the func comments above?
dfawley
approved these changes
Nov 16, 2020
davidkhala
pushed a commit
to Hyperledger-TWGC/grpc
that referenced
this pull request
Dec 7, 2020
Otherwise, when the first response is received from the grpclb server, the parent ClientConn enters TransientFailure, and the first several non-wait-for-ready RPCs will fail.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, when the first response is received from the grpclb server, the
parent ClientConn enters TransientFailure, and the first several
non-wait-for-ready RPCs will fail.
fixes #4029