Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support unix-abstract schema #4079

Merged
merged 9 commits into from Dec 22, 2020
Merged

support unix-abstract schema #4079

merged 9 commits into from Dec 22, 2020

Conversation

resec
Copy link
Contributor

@resec resec commented Dec 4, 2020

Resolving #3998

@resec resec marked this pull request as draft December 4, 2020 16:18
@resec
Copy link
Contributor Author

resec commented Dec 5, 2020

Needs help here, the "retry" test is passing on my ubuntu machine with go 1.15.6, yet it failed here.

Please point out some directions I should investigate? and how can I re-trigger the pr testing? Thanks..

@resec resec marked this pull request as ready for review December 5, 2020 08:25
@easwars easwars requested a review from dfawley December 10, 2020 21:10
dfawley
dfawley requested changes Dec 10, 2020
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The failing test looked like a flake, so I re-ran everything. A few comments inline.

internal/grpcutil/target_test.go Show resolved Hide resolved
internal/resolver/unix/unix.go Show resolved Hide resolved
internal/transport/http_util.go Outdated Show resolved Hide resolved
@dfawley dfawley added Status: Requires Reporter Clarification Type: Feature New features or improvements in behavior labels Dec 10, 2020
@dfawley dfawley added this to the 1.35 Release milestone Dec 10, 2020
@resec resec requested a review from dfawley December 11, 2020 03:37
@menghanl menghanl assigned dfawley and unassigned resec Dec 17, 2020
@dfawley dfawley removed their assignment Dec 17, 2020
@resec resec requested a review from dfawley December 21, 2020 03:47
dfawley
dfawley requested changes Dec 21, 2020
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, just a couple minor things. Thank you!

internal/grpcutil/target.go Outdated Show resolved Hide resolved
internal/grpcutil/target.go Outdated Show resolved Hide resolved
internal/grpcutil/target_test.go Outdated Show resolved Hide resolved
@resec resec requested a review from dfawley December 22, 2020 09:43
dfawley
dfawley approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@dfawley dfawley merged commit 39a500a into grpc:master Dec 22, 2020
This was referenced Mar 8, 2021
Open
Open
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@resec resec

Labels
Status: Requires Reporter Clarification Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.35 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@resec @dfawley @menghanl