Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls: control channel implementation #5046

Merged
merged 11 commits into from
Dec 15, 2021
Merged

rls: control channel implementation #5046

merged 11 commits into from
Dec 15, 2021
+1,389 −1,427

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Dec 7, 2021 •
edited
Loading

Summary of changes:

  • Implementation of the control channel to the RLS server
    • This includes the control channel connectivity state monitoring as well
  • Removed most of the existing code in the builder, balancer, picker, and rls client
    • Most of this is changing beyond recognition anyways
    • Without removing existing changes and making them boiler plate, it was not possible to break the massive PR into anything reasonable
  • Bunch of test helper functionality
    • Not all of that might be used by the tests in this PR, but selectively adding them was another pain point.

Full implementation is at #4992

RELEASE NOTES: none

@easwars easwars added the Type: Feature New features or improvements in behavior label Dec 7, 2021
@easwars easwars added this to the 1.44 Release milestone Dec 7, 2021
@easwars easwars force-pushed the rls_control_channel_changes branch from f25b5cb to a98dcd0 Compare December 7, 2021 19:07
@easwars
rls: control channel implementation

Unverified

The signing certificate or its chain could not be verified.
Certificate subject
Certificate issuer
CN sigstore-intermediate
O sigstore.dev
Learn about vigilant mode
a7b31c6
@easwars easwars force-pushed the rls_control_channel_changes branch from a98dcd0 to a7b31c6 Compare December 7, 2021 19:24
@easwars
Copy link
Contributor Author

easwars commented Dec 7, 2021

This PR is still huge, but the code under concern is mostly limited to control_channel.go and control_channel_test.go. Most of the rest of removing old code and some test wrappers which will be used much more in upcoming PRs.

@dfawley
Copy link
Member

dfawley commented Dec 8, 2021

/easycla

dfawley
dfawley reviewed Dec 9, 2021
View reviewed changes
@easwars
do not store buildOpts in controlChannel

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e252bc7
@easwars
do not store a context in controlChannel

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
75ba1ac
@easwars
wait correctly for the control channel to move out of Ready

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
caa366d
@easwars
refactor Start() in stubServer
dfca19c
@easwars
remove tmp in restartableListener

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
ba14442
@easwars
rename the LB policy to "rls_experimental"
50c4838
@easwars
make vet happy
9f71f96
@easwars
Copy link
Contributor Author

easwars commented Dec 9, 2021

Thanks for the review.

dfawley
dfawley reviewed Dec 9, 2021
View reviewed changes
@dfawley dfawley assigned easwars and unassigned dfawley Dec 9, 2021
@easwars easwars assigned dfawley and unassigned easwars Dec 10, 2021
@dfawley dfawley assigned easwars and unassigned dfawley Dec 13, 2021
@easwars easwars assigned dfawley and unassigned easwars Dec 13, 2021
@dfawley dfawley assigned easwars and unassigned dfawley Dec 15, 2021
@easwars easwars merged commit 50f8270 into grpc:master Dec 15, 2021
@easwars easwars deleted the rls_control_channel_changes branch December 15, 2021 17:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley

Assignees

@easwars easwars

Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.44 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@easwars @dfawley