grpc: handle invalid service configs by applying the default, if applicable #5238
+43
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the name resolver returns an invalid service config, and if there is no current service config on the channel, this PR attempts to apply the default service config, if one is available.
This aligns grpc-go with https://github.com/grpc/proposal/blob/master/A21-service-config-error-handling.md, specifically #4.2
This PR also makes the following changes:
nil
receiver inccBalancerWrapper
cc.balancerWrapper != nil
checks before calling methods on the balancerWrappercc.sc != nil
as the condition representing presence of current service config instead ofcc.balancerWrapper != nil
RELEASE NOTES: